-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(crypto)!: Remove unused OneTimeKey::Key
and SessionCreationError::OneTimeKeyUnknown
variants
#4194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, though the commit mentions that OneTimeKey::Signed
was removed, no such variant exists and SignedKey
certainly was not removed.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4194 +/- ##
==========================================
+ Coverage 84.89% 84.91% +0.02%
==========================================
Files 272 272
Lines 29142 29131 -11
==========================================
- Hits 24739 24738 -1
+ Misses 4403 4393 -10 ☔ View full report in Codecov by Sentry. |
…onError::OneTimeKeyUnknown` variants Signed-off-by: Kévin Commaille <[email protected]>
7d6ea39
to
190fb3f
Compare
OneTimeKey::Signed
and SessionCreationError::OneTimeKeyUnknown
variantsOneTimeKey::Key
and SessionCreationError::OneTimeKeyUnknown
variants
Oops, sorry about that. It's fixed now. |
This contained some crypto interface changes (https://github.com/matrix-org/matrix-rust-sdk-crypto-wasm/actions/runs/11604714936/job/32313920920) that would have been helpful to document in the changelog |
No blame though - it's almost impossible to keep track of this and the automated checks we have are after-the-fact, which is how I'm picking it up. |
Err, but we're using |
To clarify a bit further, every time you bump the SDK version in the WASM bindings you can use Of course all of this might become even easier once we start doing releases, hopefully next week. |
Ah, so I should not have expected it to appear in
🚀 |
That's correct, the changelog will be updated during the release, it'll be a bit of a mess the first time we do this since we have a mix of cliff entries and hand written entries but eventually things will stabilize. |
As discussed in #4171 (comment).